Reporting of INI encoding issues #12

Open

opened by LEdoian · 1 comments

LEdoian commented

Owner

QuickPlay currently does not warn, if the INI is not UTF-8, it instead replaces invalid characters with U+FFFD (this seems to be the default behaviour, I do not remember adding such feature). This means that (library) code has somehow dealt with that, but failed silently.

Since encoding issues are still common, we should inform the user that this has happened. Possibly display a toast with a warning like "The INI file does not seem to be in UTF-8, characters may display incorrectly".

(It would be fancy to do autodetection and report if some variant of UTF-16 or UTF-32 was found, but it is not really necessary and would likely create a potential for breakage.)

QuickPlay currently does not warn, if the INI is not UTF-8, it instead replaces invalid characters with U+FFFD (this seems to be the default behaviour, I do not remember adding such feature). This means that (library) code has somehow dealt with that, but failed silently. Since encoding issues are _still_ common, we should inform the user that this has happened. Possibly display a toast with a warning like "The INI file does not seem to be in UTF-8, characters may display incorrectly". (It would be fancy to do autodetection and report if some variant of UTF-16 or UTF-32 was found, but it is not really necessary and would likely create a potential for breakage.)

LEdoian added the

bug

feature-request

labels

LEdoian commented

Poster

Owner

This could probably be fixed together with other issues with the INI file like missing mandatory fields.

Sign in to join this conversation.